OSGeo / libgeotiff

Official repository of the libgeotiff project
180 stars 69 forks source link

Revise exported CMake config #72

Closed dg0yt closed 2 years ago

dg0yt commented 2 years ago

While testing 1.7.1 RC1, I found these issues with the exported cmake config:

This is adressed in PR, but not yet tested thoroughly.

Other isssue which are not adressed:

rouault commented 2 years ago

Do you believe this should go in 1.7.1 (I don't want to do too many RCs...) or can this go to a 1.7.2 with further changes ? (to be honest I hardly understand those parts of cmake stuff so I'm a bit nervous to have that as last minute changes)

dg0yt commented 2 years ago

Well, the pristine CMake config is incomplete for some static configurations. And there is another patch in vcpkg which I would like to upstream. OTOH it is not yet ready, and if nobody else uses these configurations ...

In vcpkg, liblas and pdal seem to detect the bugs in this config.