Closed dg0yt closed 2 years ago
Do you believe this should go in 1.7.1 (I don't want to do too many RCs...) or can this go to a 1.7.2 with further changes ? (to be honest I hardly understand those parts of cmake stuff so I'm a bit nervous to have that as last minute changes)
Well, the pristine CMake config is incomplete for some static configurations. And there is another patch in vcpkg which I would like to upstream. OTOH it is not yet ready, and if nobody else uses these configurations ...
In vcpkg, liblas and pdal seem to detect the bugs in this config.
While testing 1.7.1 RC1, I found these issues with the exported cmake config:
@PROJECT_NAME@_USE_STATIC_LIBS
and theBUILD_SHARED_LIBS
value when the config is consumed, but the available linkage is determined at build time.@PROJECT_NAME@_SHARED_LIBRARIES
and@PROJECT_NAME@_STATIC_LIBRARIES
shouldn't be advertised IMO. Linkage is determined at build time. The variables are either empty orlibgeotiff
.QUIET
tofind_package
.This is adressed in PR, but not yet tested thoroughly.
Other isssue which are not adressed:
@PROJECT_NAME@_USE_STATIC_LIBS
, a non-matching config should do nothing, giving other configs the chance to be considered by CMake.