Closed bencaradocdavies closed 6 years ago
@jodygarnett who can review this PR?
Can I ask what the inkscape SVG is? Can it just be a normal SVG file or are their inscape specific features...
@jodygarnett the original artwork provided by OSGeo was created in Adobe Illustrator and exported to SVG, hence the comment. I added a small rendering margin in Inkscape, and saved the edited version as Inkscape SVG to ensure reproducibility. Inkscape preserved the original Adobe Illustrator comment when saving the Inkscape SVG.
Inkscape stores extra information in its native SVG. In the case of the emblem, this might have no effect, but in general Inkscape SVG keeps font information and letterspacing and manual kerning that is not honoured by some other SVG rendering engines and can lead to very noticeable differences in rendering. Inkscape can export to plain SVG, but I have found it necessary to convert all text objects to paths to ensure consistent rendering. As I said, that might not be necessary in this case as there is no text.
The Inkscape SVG is here so others can reproduce this work, and adds convenient features such as remembering the resolution of the most recent export. Would you like me to add a plain SVG as well? Would this add anything over the original Adobe Illustrator SVG?
Okay, for actual saving we try and convert the letters to outline. Only using text for the template. On Fri, Nov 10, 2017 at 3:28 PM Ben Caradoc-Davies notifications@github.com wrote:
@jodygarnett https://github.com/jodygarnett the original artwork provided by OSGeo was created in Adobe Illustrator and exported to SVG, hence the comment. I added a small rendering margin in Inkscape, and saved the edited version as Inkscape SVG to ensure reproducibility. Inkscape preserved the original Adobe Illustrator comment when saving the Inkscape SVG.
Inkscape stores extra information in its native SVG. In the case of the emblem, this might have no effect, but in general Inkscape SVG keeps font information and letterspacing and manual kerning that is not honoured by some other SVG rendering engines and can lead to very noticeable differences in rendering. Inkscape can export to plain SVG, but I have found it necessary to convert all text objects to paths to ensure consistent rendering. As I said, that might not be necessary in this case as there is no text.
The Inkscape SVG is here so others can reproduce this work, and adds convenient features such as remembering the resolution of the most recent export. Would you like me to add a plain SVG as well? Would this add anything over the original Adobe Illustrator SVG?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OSGeo/osgeo/pull/157#issuecomment-343613841, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmbseDadTDTQKvuFrNSERRW6vkHiXI0ks5s1NwEgaJpZM4QKHnU .
--
Jody Garnett
Yes @jodygarnett agreed on text to outline, but as this SVG contains no text, there should be no difference.
One last question, should we just replace the original SVG?
Trying to avoid a situation where we require participants to install Inkscape (otherwise why use a standard file format).
I thought we leave the original SVG well enough alone. If there is something wrong with the Inkscape version, we will need the original. I checked using one other tool (Viewnior) and the page size seems OK. I think that in this case the Inkscape version will work fine with other tools. I am just identifying it as Inkscape to make the process transparent.
Okay, sounds good - we can make a note in the readme later (just want to be careful not to cause more confusion, we already have off brand logos circulating).
Thanks @jodygarnett.
The 32x32 PNG has been applied to the OSGeo Jira instance in Atlassian cloud: https://osgeo-org.atlassian.net/secure/Dashboard.jspa
(Jira only accepts PNG not favicon for its "favicon").