search

OSGeo / proj-datumgrid

Historic repository for proj datum grids. New developments are at https://github.com/OSGeo/PROJ-data
40 stars 33 forks source link

Added grids for Iceland #67

Closed dalia2 closed 4 years ago

dalia2 commented 4 years ago

added the grids to europe directory, editted README.EUROPE and expected_europe.lst

kbevers commented 4 years ago

This is great @dalia2. @rouault have already commented on the few things that need to be fixed before this is ready to merge. I is great that you have added test material inside the ISL-file. I haven't yet had the possibility to run them but I will make sure to do so before we merge this.

rouault commented 4 years ago

You should rebase on master as there are conflicts. For consistency with current pratice, the text in README.europe should be split into 2 parts. The grids somewhere before the "## Included init-files" section, and the init ISL file after it

dalia2 commented 4 years ago

Thank you for your reviews, and sorry for mistakes. I updated ISL file using your suggestions. Regarding the failures of gie. I think something is wrong with gie itself, it calculates wrongly. Or am I doing something wrong regarding gie? Should I delete these three examples with gie?

FAILURE in ISL(166), i put a line in PROJ: echo -21.930875 64.1421888889 0 0 | cct +proj=pipeline +step +proj=cart +ellps=danish +step +init=c:\PROJ\ISL:REYK19_ISN93 +step +proj=cart +inv +ellps=GRS80 +step +init=c:\PROJ\ISL:ISN93_LAM output : 357557.5871 407700.8896

FAILURE in ISL(173): echo -34.50875 64.1421888889 0 0 | cct +proj=pipeline +step +inv +proj=longlat +pm=copenhagen +step +proj=cart +ellps=danish +step +init=c:\PROJ\ISL:REYK19_ISN93 +step +proj=cart +inv +ellps=GRS80 +step +init=c:\PROJ\ISL:ISN93_LAM output: 357557.5871 407700.8896

FAILURE in ISL(186): echo -21.9933555556 64.1533913888889 0 0 | cct +proj=pipeline +step +proj=cart +ellps=intl +step +init=c:\PROJ\ISL:HJ_ISN93 +step +proj=cart +inv +ellps=GRS80 +step +init=c:\PROJ\ISL:ISN93_LAM output: 354399.1771 409035.1420

FAILURE in ISL(217): I fixed it

FAILURE with init=ISL:ISN2016_ISH2004_v I fixed it.

FAILURE in ISL(370): I fixed it

FAILURE in ISL(387): I fixed it

In some cases I am using this expression (Example: echo -34.50875 64.1421888889 0 0 | cct init=ISL:RJ_W), is this syntax correct?:

kbevers commented 4 years ago

With the latest commit I think we have sorted all that needed to be fixed. Good job, @dalia2. Are you happy with this as it is now?

dalia2 commented 4 years ago

Yes, i am happy with this as it is. Thank you for your help.

rouault commented 4 years ago

@dalia2 May I ask a complementary work ? In provision for a future mass conversion to GeoTIFF, could you update https://github.com/OSGeo/proj-datumgrid/blob/master/filelist.csv to add entries for the new files ? At least for the classic geoid models. I'm not yet sure about how we will deal with the .ct2 + .gtx files used for the velocity models.

rouault commented 4 years ago

and regarding filelist.csv, the NTv2 grids as well