search

OSGeo / shapelib

Official repository of shapelib
Other
141 stars 66 forks source link

Fix writing Date value to DBF #102

Closed thbeu closed 9 months ago

thbeu commented 9 months ago

Fix for #98. Date value should not be reformatted.

rouault commented 9 months ago

Does that mean that those new functions have only been compile tested when introduced... ? Could we have some unit tests please...

thbeu commented 9 months ago

Does that mean that those new functions have only been compile tested when introduced... ?

I tested read and write, but not read-back.

Could we have some unit tests please...

I promise, I tried hard, however it's a non-trivial task to add a simple unit test to this repo.

  1. 79 is still open

  2. Unit tests do not run in my IDE (being VS), which means I need to switch between WSL and VS a lot.
  3. Most of the application or contrib code neither take FTDate or FTLogical into account. I tried to get it up-to-date, but it was so much work, that I gave up pretty soon.
rouault commented 9 months ago

however it's a non-trivial task to add a simple unit test to this repo.

fair enough