search

OSGeo / shapelib

Official repository of shapelib
Other
141 stars 66 forks source link

Update CMake build dependencies: Remove include(CTest) (/w enable_testing() still set) and fix Google Benchmark #162

Closed thbeu closed 1 month ago

thbeu commented 1 month ago
  1. CTest dependency is not required and considered controversial because it introduces extra build targets
  2. Google Benchmark can no longer be downloaded with shallow flag set
rouault commented 1 month ago
  1. CTest dependency is not required and considered controversial because it introduces extra build targets

really ? by whom ? Or is it just "include(CTest)"? But isn't that necessary to run ctest?

thbeu commented 1 month ago
  1. CTest dependency is not required and considered controversial because it introduces extra build targets

really ? by whom ? Or is it just "include(CTest)"? But isn't that necessary to run ctest?

I read about it here and here, for example.

rouault commented 1 month ago

I read about it here and here, for example.

ok, thanks, Craig Scott is indeed an authoritative source regarding CMake topics. So just enable_testing() as we do is fine

rouault commented 1 month ago

@thbeu https://github.com/OSGeo/shapelib/pull/163 is needed as a follow up