search

OSGeo / shapelib

Official repository of shapelib
Other
141 stars 66 forks source link

Fix UTF8 hook functions #82

Closed thbeu closed 10 months ago

thbeu commented 10 months ago

This got "broken" by 01ee129f7d53b2619b2a1e8e5e5ea2553caaaf67.

You can see these warnings in https://github.com/OSGeo/shapelib/actions/runs/7152273225/job/19477427836.

D:/a/shapelib/shapelib/safileio.c(168,20): warning C4113: 'SAFile (cdecl )(const char ,const char *)' differs in parameter lists from 'SAFile (cdecl )(const char ,const char ,void )' [D:\a\shapelib\shapelib\build\shp.vcxproj] D:/a/shapelib/shapelib/safileio.c(169,21): warning C4113: 'int (cdecl )(const char )' differs in parameter lists from 'int (cdecl )(const char ,void *)' [D:\a\shapelib\shapelib\build\shp.vcxproj]

rouault commented 10 months ago

You can see these warnings in https://github.com/OSGeo/shapelib/actions/runs/7152273225/job/19477427836.

ouch, C is so a lax language. Crazy it doesn't error out. Perhaps we should enable warnings as errors then

Thanks