search

OSGeo / shapelib

Official repository of shapelib
Other
141 stars 66 forks source link

CI: treat all warnings as errors #84

Closed thbeu closed 10 months ago

thbeu commented 10 months ago

See https://github.com/OSGeo/shapelib/pull/82#issuecomment-1903963244

thbeu commented 10 months ago

https://github.com/OSGeo/shapelib/actions/runs/7612427623/job/20730024777?pr=84 reveals another issue with bBigEndian now which needs refactoring as reported in #36.

rouault commented 10 months ago

We should definitely not put warnings-as-errors in the CMakeLists.txt as default. This is too risky. This should only be set in the CI scripts

thbeu commented 10 months ago

We should definitely not put warnings-as-errors in the CMakeLists.txt as default. This is too risky. This should only be set in the CI scripts

Done. CMake ≥ 3.24 is required according to https://cmake.org/cmake/help/latest/variable/CMAKE_COMPILE_WARNING_AS_ERROR.html#variable:CMAKE_COMPILE_WARNING_AS_ERROR.

rouault commented 10 months ago

Do you mind reworking the git history to fold the first 2 commits in a single one? Thanks

thbeu commented 10 months ago

Do you mind reworking the git history to fold the first 2 commits in a single one? Thanks

Check again :-)

rouault commented 10 months ago

Excellent. Thanks again for all your work on shapelib

thbeu commented 10 months ago

Excellent. Thanks again for all your work on shapelib

Thanks for the lib after all! I am considering to work on #16 and #36. Let me know if this is not OK for you.