search

OSIPI / TF2.4_IVIM-MRI_CodeCollection

OSIPI TF2.4: IVIM MRI code collection
Apache License 2.0
9 stars 27 forks source link

Testing/add etp and add configuration #20

Closed etpeterson closed 10 months ago

oliverchampion commented 10 months ago

Hey! Several questions:

What is the reason for now initializing the code for every voxel?: Adding self.initialize(bounds, initial_guess, fitS0, thresholds, prior_in) to the ivim_fit routine, instead of running it in the super? I imagine typically you want to fit a full image with similar settings. Then, if you want to change bounds, you could run initialize again after fitting the image?

oliverchampion commented 10 months ago

Moreover, the Bayesian approach needs an initial guess that is reasonable. This is now taken from the segmented fit. If the segmented fit is broken, it is expected that the Bayesian will not work well. :)

oliverchampion commented 10 months ago

I think for the Bayesian wrapper you can remove line 77 " fit_results=fit_results+(1,)"

oliverchampion commented 10 months ago

Unfortunately, I cannot run the tests on segmented fit without the json file (which is now being ignored by .gitignore). My expectation is that the bounds implemented for my segmented fit are not working well (i.e. not well translated to the individual fits). Does the segmented fit work for the fit bounds given in my wrapper?

oliverchampion commented 10 months ago

I think I've fixed the errors in segmented and bayesian. Still confused about the initialisation.