OSIPI / TF2.4_IVIM-MRI_CodeCollection

OSIPI TF2.4: IVIM MRI code collection
Apache License 2.0
9 stars 27 forks source link

Update the github workflow #42

Closed etpeterson closed 6 months ago

etpeterson commented 6 months ago

Feature description

The github workflow is generating deprecation warnings and should be updated.

Describe the solution

Both workflows are generating these warnings. Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. They are still running, but should be updated.

Describe alternatives

No response

Additional context

No response

Are you working on this?

None

Unique-Usman commented 6 months ago

hello @etpeterson let me fix this then, I can take another issue.

etpeterson commented 6 months ago

Actually, and strangely this broke the Algorithm Analysis workflow. https://github.com/OSIPI/TF2.4_IVIM-MRI_CodeCollection/actions/runs/8114822453

I see this error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

Any ideas why?

Unique-Usman commented 6 months ago

None yet, let me try look into it. I guess it is due to the update.

etpeterson commented 6 months ago

Thanks. To get those to run on your branch you can temporarily add yourself or your branch in the filter for the workflow. It's near the top of the workflow file. That way you can iterate easily and remove it later for the final merge.

Unique-Usman commented 6 months ago

Thanks. To get those to run on your branch you can temporarily add yourself or your branch in the filter for the workflow. It's near the top of the workflow file. That way you can iterate easily and remove it later for the final merge.

Thanks

Unique-Usman commented 6 months ago

@etpeterson I was able to fix the issue, the upload_artifact and download_artifact v4 actions are not yet supported for GHES. So, I had to downgrade it back to v3.

etpeterson commented 6 months ago

Ok, thanks!