search

OSIPI / TF2.4_IVIM-MRI_CodeCollection

OSIPI TF2.4: IVIM MRI code collection
Apache License 2.0
9 stars 27 forks source link

Generate a variety of testing data and came up command_line version of sim_vim_sig.py #55

Closed Unique-Usman closed 5 months ago

Unique-Usman commented 6 months ago

Describe the changes you have made in this PR

Update to this pull request - https://github.com/OSIPI/TF2.4_IVIM-MRI_CodeCollection/issues/41

Link this PR to an issue [optional]

Fixes #10

etpeterson commented 6 months ago

Is this a duplicate of your other one? https://github.com/OSIPI/TF2.4_IVIM-MRI_CodeCollection/pull/51

Unique-Usman commented 6 months ago

Is this a duplicate of your other one? #51

No, This is the correct branch that solve the issue. I had to start from fresh. I can close the other one.

etpeterson commented 6 months ago

I can close the other one.

Sounds good.

etpeterson commented 6 months ago

I see you made changes but because you force pushed and squashed them into a single commit I can't see your changes. In general try to avoid force pushes and history rewriting. I also commented about that to someone else and you can see my reasoning here.

Unique-Usman commented 6 months ago

Contributor

I am very sorry, I will take note of that. Your reason make sense. Having all the commits is also a good way to follow the commit process for a branch/changes. Thanks for the knowledge.