OSInside / kiwi

KIWI - Appliance Builder Next Generation
https://osinside.github.io/kiwi
GNU General Public License v3.0
307 stars 152 forks source link

vmx descriptor does not take into acount bundle_format configuration for the filename inside the config #2125

Open gmoro opened 2 years ago

gmoro commented 2 years ago

When using bundle_format the final vmx file has the wrong (not formatted) name of the .vmdk file inside the descriptor for the disk.

e.g. scsi0:0.fileName = "image_name.vmdk"

schaefi commented 2 years ago

Hmm, looking at kiwi/tasks/result_bundle.py all result files marked with "use_for_bundle" should be treated the same when there is a bundle_file_format_name

I need to dig deeper into that part

schaefi commented 2 years ago

I cannot reproduce this issue. Here is what I did

<type ... bundle_format="%N-foo-%A" format="vmdk">

results in

ll /tmp/mytest-15.3
total 1.6G
-rw-r--r-- 1 root root  15M Apr 27 18:48 Leap-15.3_appliance.x86_64-1.15.3.changes
-rw-r--r-- 1 root root  49K Apr 27 18:48 Leap-15.3_appliance.x86_64-1.15.3.packages
-rw-r--r-- 1 root root 1.1G Apr 27 18:48 Leap-15.3_appliance.x86_64-1.15.3.raw
-rw-r--r-- 1 root root 1.7K Apr 27 18:48 Leap-15.3_appliance.x86_64-1.15.3.verified
-rw-r--r-- 1 root root 788M Apr 27 18:48 Leap-15.3_appliance.x86_64-1.15.3.vmdk
-rw-r--r-- 1 root root  678 Apr 27 18:48 Leap-15.3_appliance.x86_64-1.15.3.vmx
drwxr-xr-x 3 root root 4.0K Apr 27 18:40 build
-rw-r--r-- 1 root root  14K Apr 27 18:48 kiwi.result
-rw-r--r-- 1 root root 1.5K Apr 27 18:48 kiwi.result.json
kiwi-ng result bundle --target-dir /tmp/mytest-15.3/ --bundle-dir /tmp/mytest-15.3-bundle --id 0

results in

-rw-r--r-- 1 root root 2.5M Apr 27 18:49 Leap-15.3_appliance-foo-x86_64.changes.xz
-rw-r--r-- 1 root root  49K Apr 27 18:49 Leap-15.3_appliance-foo-x86_64.packages
-rw-r--r-- 1 root root 1.7K Apr 27 18:49 Leap-15.3_appliance-foo-x86_64.verified
-rw-r--r-- 1 root root 190M Apr 27 18:48 Leap-15.3_appliance-foo-x86_64.vmdk.xz
-rw-r--r-- 1 root root  105 Apr 27 18:49 Leap-15.3_appliance-foo-x86_64.vmdk.xz.sha256
-rw-r--r-- 1 root root  678 Apr 27 18:49 Leap-15.3_appliance-foo-x86_64.vmx

the bundle format was applied to any result file marked as use_for_bundle

From my perspective it worked

gmoro commented 2 years ago

look in the .vmx file, the scsi0:0.fileName = "image_name.vmdk" will have the wrong file name, the descriptor is generated before during the image conversion step.

gmoro commented 2 years ago

sorry for the poor bug report, was in a rush, should be more understandable now

schaefi commented 2 years ago

Ah inside of the .vmx. Yes you are right, sorry I did understand that in a different way

schaefi commented 2 years ago

@gmoro I'm sorry I won't have time to look into this one. I think you already did some research and assigned the issue to you for the moment. Just drop yourself if you won't have time too. Thanks in advance