oem-shutdown doesn't shutdown but reboot the machine

ampresent commented 8 months ago

Problem description

<oem-shutdown>true</oem-shutdown> doesn't really shutdown but reboot the machine.

Expected behaviour

The machine is to be shutdown after installation.

Steps to reproduce the behaviour

Create a hybrid iso image. With "oem-shutdown" set to true.

    <type image="oem" filesystem="ext4" installiso="true" installboot="install" firmware="uefi" kernelcmdline="console=ttyS0">
        <bootloader name="grub2" console="serial" timeout="10"/>
        <oemconfig>
            <oem-systemsize>2048</oem-systemsize>
            <oem-unattended>true</oem-unattended>
            <oem-swap>true</oem-swap>
            <oem-swapsize>200</oem-swapsize>
            <oem-multipath-scan>false</oem-multipath-scan>
            <oem-shutdown>true</oem-shutdown>
        </oemconfig>
    </type>

kiwi build

Start a virtual machine with qemu

sudo /usr/libexec/qemu-kvm -m 20480 -drive file=./xxx.qcow2,format=qcow2  -cdrom ./build/xxx.x86_64-1.0.0.install.iso -net nic -net user --enable-kvm -cpu host -boot d -serial mon:stdio

Waiting for it to finish installation
It reboots

OS and Software information

KIWI version: 9.25.21
Operating system host version: Rocky Linux 9.2
Operating system target version: CentOS 8.5.2111
Open Build Service version (N/A if not using OBS): N/A
Koji version (N/A if not using Koji): N/A

I suspect the issue is resulted from this line, where reboot -p might mean reboot rather than poweroff. https://github.com/OSInside/kiwi/blob/5e40229b1c75d0a36df17c2565bd23304168ad81/dracut/modules.d/99kiwi-dump-reboot/kiwi-dump-reboot-system.sh#L33

schaefi commented 8 months ago

Yeah looks like a bug. I think we should even consider to call

systemctl halt

as we have a running systemd inside of the initrd

schaefi commented 8 months ago

I tested an image with the provided PR, after deploy you will see messages like

[  OK  ] Reached target System Shutdown.
[  OK  ] Reached target Late Shutdown Services.
[  OK  ] Finished System Halt.
[  OK  ] Reached target System Halt.
[   30.313607][    T1] reboot: System halted

I think this is the expected behavior. Please comment on the PR in case there are objections.

Thanks much

OSInside / kiwi