search

OSInside / kiwi

KIWI - Appliance Builder Next Generation
https://osinside.github.io/kiwi
GNU General Public License v3.0
300 stars 152 forks source link

Lookup distro provided BLS entries for zipl #2502

Closed schaefi closed 6 months ago

schaefi commented 6 months ago

Check if there is already an entry file name produced by the distribution logic/policy. If we can find an already present entry name, prefer this name over the kiwi naming policy

schaefi commented 6 months ago

@Conan-Kudo During my tests on s390 I understand that some distros doesn't have a concept for the loader entries of BLS zipl and some others have. On Fedora the policy is based on a machine-id naming convention as documented by IBM. kiwi's default naming policy is based on the OS ID which I think is the better concept. Nevertheless kiwi has to respect the distro over its own policies. Thus this change looks up an eventually created entries.conf and takes this name rather than producing its own version of it.

This is important because if there are multiple BLS entry configs at the time zipl is called this leads to a menu selection and it becomes unclear if the correct entry is set as the default

schaefi commented 6 months ago

I will run the integration test builds to make sure the boot has only one entry for fedora and it uses the fedora naming policy. No merge until I have tested it please

Conan-Kudo commented 6 months ago

Sure! Just leave a comment once you've verified it!

schaefi commented 6 months ago

Sure! Just leave a comment once you've verified it!

verified and works