search

OSInside / kiwi

KIWI - Appliance Builder Next Generation
https://osinside.github.io/kiwi
GNU General Public License v3.0
300 stars 152 forks source link

Fix setup of discoverable partitions #2518

Closed schaefi closed 6 months ago

schaefi commented 6 months ago

Make sure GUI and typecode are set. This Fixes #2517

Conan-Kudo commented 6 months ago

Do we want the partition UUID and the type UUID to be the same? I don't think so... I think the idea here is that we only set the type UUID, right @kraxel?

schaefi commented 6 months ago

I think it looks inconsistent if the typecode and the GUID are different. If they vary systemd-boot as an example would be able to identify the root device and boot from it, but the same device would have a different /dev/disk/by-partuuid device node name. So I did that for consistency and think it doesn't hurt

Conan-Kudo commented 6 months ago

Well it creates the problem that Linux will get confused when trying to enumerate partitions when multiple formatted disks are present.

schaefi commented 6 months ago

ah yes you are right, because the ID's are no longer unique

schaefi commented 6 months ago

I will adapt ... tomorrow ;) late here

kraxel commented 6 months ago

Do we want the partition UUID and the type UUID to be the same? I don't think so... I think the idea here is that we only set the type UUID, right @kraxel?

Yes. The Type-UUID specified what kind of partition this is, and the UUID should be unique for each partition. I think sfdisk already generates a UUID when creating a gpt entry , so there should be nothing to do.

schaefi commented 6 months ago

ok, so the updated patch should address it correctly now