search

OSInside / kiwi

KIWI - Appliance Builder Next Generation
https://osinside.github.io/kiwi
GNU General Public License v3.0
300 stars 152 forks source link

Fixed runtime checks for dracut module packages #2526

Closed schaefi closed 5 months ago

schaefi commented 6 months ago

Unfortunately the packaging of kiwi on Debian follows different naming conventions for dracut module packages which causes the runtime check to fail. This commit allows to check for multiple package names and adds the variants used on Debian. This Fixes #2524

Conan-Kudo commented 6 months ago

Did we try asking the Debian maintainer to fix it?

schaefi commented 6 months ago

Did we try asking the Debian maintainer to fix it?

We can try. @glaubitz What's your take on the issue ? Thanks

glaubitz commented 5 months ago

Did we try asking the Debian maintainer to fix it?

Renaming packages in Debian is not trivial, so I prefer not to rename these packages. It also makes sense to keep the naming scheme.

Did we try asking the Debian maintainer to fix it?

We can try. @glaubitz What's your take on the issue ? Thanks

I prefer your fix. You should never assume that packages share all the same names across distributions.

schaefi commented 5 months ago

@Conan-Kudo expected feedback, renaming is hard and will also take a long time. I would like to go ahead with the proposed solution. Thoughts ?

Conan-Kudo commented 5 months ago

If we're going with the rule "don't assume package names" then we have to change this fix completely. The package names need to be shifted to configuration to make it patchable.

schaefi commented 5 months ago

If we're going with the rule "don't assume package names" then we have to change this fix completely. The package names need to be shifted to configuration to make it patchable.

Hmm, yeah ... I was too lazy but you are right

schaefi commented 5 months ago

@Conan-Kudo I refactored in a way that we provide a yaml file with information about the package names for consumption by the runtime checker code: runtime_checker_metadata.yml If need be the file can be extended with further information used by runtime checks. For the moment only package_names are added