search

OSInside / kiwi

KIWI - Appliance Builder Next Generation
https://osinside.github.io/kiwi
GNU General Public License v3.0
300 stars 152 forks source link

package: Unconditionally include patches and number all sources and patches #2556

Closed Conan-Kudo closed 4 months ago

Conan-Kudo commented 4 months ago

This ensures that stuff is applied reliably and all sources and patches are included as expected.

schaefi commented 4 months ago

@Conan-Kudo the SUSE package checks also checks the changelog for an entry of the form

Added patch kiwi-revert-bls-default-for-suse.patch

In kiwi we create the changelog from the git history. My latest submission got declined because we added the patch file but the produced changelog missed the information from above

Could you write the commit message of this PR in a way that the sentence from above is part of the commit message text ?

Thanks a ton

Conan-Kudo commented 4 months ago

Looks good, thanks

out of curiosity, why does the patch numbering starts with 1001 ?

If this package is forked by SLE downstream and backports are made, they can be in 0~1000.

schaefi commented 4 months ago

Looks good, thanks out of curiosity, why does the patch numbering starts with 1001 ?

If this package is forked by SLE downstream and backports are made, they can be in 0~1000.

Ah ok got it

Conan-Kudo commented 4 months ago

For example: https://src.fedoraproject.org/rpms/kiwi/blob/rawhide/f/kiwi.spec

Conan-Kudo commented 4 months ago

@schaefi is the commit message sufficient now?

schaefi commented 4 months ago

@schaefi is the commit message sufficient now?

Only God knows that. @aplanas can you double check if it's enough that the name of the patch file appears in the changelog or do we also need a specific format sentence like "Added patch ..." ? Thanks