Initial support for ostree based systems

OSInside / kiwi

KIWI - Appliance Builder Next Generation

https://osinside.github.io/kiwi

GNU General Public License v3.0

300 stars 152 forks source link

Initial support for ostree based systems #2557

Open travier opened 4 months ago

travier commented 4 months ago

defaults: Add method to check for ostree case

Temporary method to place all ostree specific code paths behind a single check. May be converted to configuration option later.

bootloader/config/grub2: Handle ostree case for BLS configs

Do not replace but append to the existing kernel command line as it is correct
Do not fix the path to the kernel & initrd as those are also correct

system/kernel: Find kernel in ostree case

kiwi/builder/live: Handle ostree case

Do not rebuild the initrd in the ostree case and use the one from the ostree commit instead. It is expected that it includes all the needed modules.

kiwi/bootloader/config/grub2: Handle ostree case

See: https://github.com/OSInside/kiwi/issues/38

travier commented 4 months ago

This is definitely work in progress. I'm looking for suggestions on how we should implement this properly.

schaefi commented 4 months ago

This is definitely work in progress. I'm looking for suggestions on how we should implement this properly.

Thanks for looking into this :+1: much appreciated. I made some comments and maybe I understand the ostree better when we meet at oSC :)

travier commented 4 months ago

... maybe I understand the ostree better when we meet at oSC :)

Unfortunately I'm struggling to get funding for travelling to DevConf.CZ so it's unlikely that I'll be able to go to oSC this year :(

travier commented 3 months ago

This is still hackish but a bit less 😅

Conan-Kudo commented 3 days ago

@travier Couple of things here:

Could you rebase this to fix the conflicts?
What are you missing to turn this into something that we can review and merge?

travier commented 3 days ago

Could you rebase this to fix the conflicts?

Will do.

What are you missing to turn this into something that we can review and merge?

I need help figuring out:

How to fix the Live ISO build: https://github.com/OSInside/kiwi/issues/38#issuecomment-2144841679
How to make a clean integration: https://github.com/OSInside/kiwi/issues/38#issuecomment-2179353264
- This probably needs a general design discussion as I'm not familiar enough with kiwi's internals yet

Conan-Kudo commented 3 days ago

@schaefi @travier Is there a time where we could have a dedicated meeting for this? We should try to get this hammered out asap as we want to start moving things for F42 in the spring.

travier commented 3 days ago

Friday is usually a good time for me.

schaefi commented 3 days ago

@schaefi @travier Is there a time where we could have a dedicated meeting for this? We should try to get this hammered out asap as we want to start moving things for F42 in the spring.

This week and next week I won't be able to make it. I will be traveling to NUE and next week I'm in Portland for a workshop. The week after we can schedule a meeting and Friday is also a good day for me. That would mean October 18th

Conan-Kudo commented 3 days ago

That works for me too.