search

OSInside / kiwi

KIWI - Appliance Builder Next Generation
https://osinside.github.io/kiwi
GNU General Public License v3.0
300 stars 152 forks source link

Better error handling on grub vendor dir lookup #2567

Closed schaefi closed 3 months ago

schaefi commented 3 months ago

The strings command is used to lookup the in-efi binary encoded vendor path. However, if the strings or bash command is not availabe on the build host, the command silently failed and moved into the standard (non vendored) EFI boot path. This can lead to a broken boot for those distros and image targets which requires a vendor directory and should lead to an error message instead of a successful image build. This Fixes #2565

schaefi commented 3 months ago

What's the bash command you're referring to? Could we depend on that instead?

That is covered by the raise_on_command_not_found=True when calling strings as a script through bash.

We have no requirement on the packaging level for any shell interpreter but we also offer a bash completion for kiwi, so maybe it would be a good idea to add a requirement ?

Conan-Kudo commented 3 months ago

I think we probably should just express a dependency on bash.

schaefi commented 3 months ago

I think we probably should just express a dependency on bash.

ok, I updated the spec template. Not sure if the names needs to be differentiated between distros ?