Hipped roofs are shown flat

[chram2]

Roofs tagged shape = hipped are shown flat. Is hipped already supported? Could it shown as gabled temporarily?

[natrius]

Why is this closed @kekscom ? I have the same problem right now. hipped and half-hipped does not get rendered at all https://osmbuildings.org/?lat=47.82743&lon=13.03972&zoom=18.0&tilt=39&rotation=177

https://github.com/OSMBuildings/OSMBuildings/issues/133 i read this one and if i understand it correctly it should at least rendered as gabled.

[kekscom]

Agreed this deserves explanation.

This is what's currently implemented:

• [x] cone
• [x] dome
• [x] pyramid
• [x] skillion (only with roof direction tagged)
• [x] gabled
• [ ] hipped -> fallback: flat
• [ ] half-hipped -> fallback: flat
• [ ] gambrel -> fallback: gabled
• [ ] mansard -> fallback: gabled
• [ ] round
• [x] onion
• [x] flat (default)

I'm open for implementing the missing ones as feature request. Please don't expect a solution soon.

Everything not behaving according to this list is a bug and may be reported as this. Please provide coordinates and an OSM id. Ideally a running example.

[natrius]

Thanks a lot for the explanation.

So, its now as expected, so this would be feature request :)

[kekscom]

Good news I briefly tested falling back to gabled for hipped and half-hipped and it looks promising. More very soon.

Bad news (affects #193) Deeper down in roof processing it seems rounded roofs are automatically set to flat. I'm trying a fix here.

[JulienPalard]

Hi, thanks @kekscom to work on this! Near my house there's OSM ID 131397132 which may be interesting to test for hipped roofs. A picture can be found here for comparison.

[kekscom]

Thanks for this! It looks like we won't be able to render curved footprints with gabled roofs. but the round parts are possible. Still, round needs to be done.

[kekscom]

Example from #193 for round roofs: https://www.openstreetmap.org/way/97260549 this building and the one north from it. https://osmbuildings.org/?lat=47.82850&lon=13.03868&zoom=20.0&tilt=41&rotation=11

[natrius]

May i suggest make a new issue @kekscom like "Progress on roof-shapes" and write the progress there. So everybody can comment there, centralized and from the issue title its clear and it can be found. People may not look at this issue if they are searching for another shape. As far as i'm aware you can even pin issues or something like this - have not tried that yet.

[natrius]

@kekscom

Can you make the fallback for hipped and half-hipped gabled as well? It would look so much better right now.

[kekscom]

May i suggest make a new issue @kekscom like "Progress on roof-shapes" and write the progress there. So everybody can comment there, centralized and from the issue title its clear and it can be found. People may not look at this issue if they are searching for another shape. As far as i'm aware you can even pin issues or something like this - have not tried that yet.

@natrius good idea. I've started a Wiki page for this. https://github.com/OSMBuildings/OSMBuildings/wiki/Supported-roof-shapes

[kekscom]

@kekscom

Can you make the fallback for hipped and half-hipped gabled as well? It would look so much better right now.

You mean gabled? Would be simple.

[natrius]

Uh, yes, bad writing on my side. Like this

• hipped -> fallback: gabled
• half-hipped -> fallback: gabled

and not "flat". I think its a better fallback than "flat". (Besides: I noted that i should tag the direction for skillion, good to know ^^)

[kekscom]

I'll take care.

[kekscom]

Changed. Please verify:

hipped -> fallback: gabled half-hipped -> fallback: gabled

[natrius]

Verified, its working. If you wanna check https://osmbuildings.org/?lat=47.82705&lon=13.03981&zoom=19.2&tilt=45&rotation=-126 or ID 97260686 or https://www.openstreetmap.org/way/97260686

Thank you! (I changed the Wiki-Page already)