search

OSMCha / osmcha-frontend

Frontend for the osmcha-django REST API
https://osmcha.org
ISC License
119 stars 37 forks source link

Remove or increase limit on rating #723

Open Kovoschiz opened 4 months ago

Kovoschiz commented 4 months ago

I'm submitting a feature request

Brief Description

Remove or delay "request was throttle" HTTP 429 on https://osmcha.org/api/v1/changesets/*/set-harmful/ and https://osmcha.org/api/v1/changesets/*/set-good

What is the motivation / use case for this feature?

Flagging a series of low to single object count changesets for follow-up (I don't care about good/bad) ## Other Information / context:

I don't know whether this is for containing server load, or abuse. For the latter, this should be measured by the number of objects affected, not per changeset which can be of any size.

matkoniecz commented 1 month ago

Note that some people spammed pointless comments using osmcha, this limits how much pointless spam they can create.

pwithnall commented 1 month ago

If they’re spamming, their accounts should get blocked by moderators, surely? The request rate limiting makes osmcha significantly less useful for good-faith users to use to review large (or even medium) numbers of changesets.

matkoniecz commented 1 month ago

their accounts should get blocked by moderators, surely?

Well, it would happen afterwards and meantime they would as much as osmcha/changeset rate limiting would allow.

Kovoschiz commented 1 month ago

Can't giving thumbs and commenting be limited separately?

matkoniecz commented 1 month ago

Both result in changeset comment and trigger the same notification for affected user, right?

pwithnall commented 1 month ago

Giving thumbs does not result in a changeset comment unless the OSMCha user has configured one (‘Review Comments Template’ in their OSMCha account settings). I have mine set to blank (no comment).

matkoniecz commented 1 month ago

Then if thumbs up remain in osmcha - then separate action limit would make sense, probably