search

OSMPH / papercut_fix

Tracking data fixing requests for the OSMPH community
8 stars 2 forks source link

Contributor is adding PSA boundaries to OSM #81

Closed govvin closed 3 years ago

govvin commented 3 years ago

This issue was first reported by Eugene in the Telegram hangout.

OSMCHA filter of changesets citing "Philippines (PHL) Administrative Boundary Common Operational Database (COD-AB), NAMRIA, PSA" as source: https://osmcha.org/?aoi=48f14d28-7be9-41e8-a12f-48f1af660523

seav commented 3 years ago

Added a comment on one of the user's changesets: https://www.openstreetmap.org/changeset/100947120

seav commented 3 years ago

I did a spot check with one CamSur municipality and I can confirm that the added boundary matches the IMTWG dataset.

govvin commented 3 years ago

I also sent a DM. Let's wait for the user to respond before proceeding with next steps.

govvin commented 3 years ago

The contributor has responded positively, and is willing to help resolve the issue.

I already asked whether the rollback is something they can do on their own, or would need assistance or advice. The user was invited to join the ticket, or the Telegram group, to co-ordinate the resolution of this ticket.

govvin commented 3 years ago

User indicated their willingness to remove affected elements, or attempt a roll-back, on their own.

govvin commented 3 years ago

User is attempting roll-backs but is now asking for assistance.

Is anyone willing to take point for this ?

Timmy-Tesseract commented 3 years ago

I just tested reverting a few of the changesets in questions (without uploading) and there were only very minor conflicts. As long as reverting happens in correct reverse order there shouldn't be any big issues.

But for boundaries that were newly added it might be better if we just delete them manually as the mapper also did a lot of river tracing within the same changesets.

ianlopez1115 commented 3 years ago

Consider reverting the most recent changesets first then work your way towards less recent work.

I'm willing to revert affected areas in and closest to Naga City.

govvin commented 3 years ago

@ianlopez1115 , looks like it's mostly around Naga

image http://overpass-turbo.eu/s/17xv

We probably should compile a check list of municipal boundaries that needs review, so we could avoid stepping on each other toes. I'm reviewing the data now.

govvin commented 3 years ago

Looks like it's the following relations that has to be reviewed. If you successfully completed a roll-back of these elements, please add a tick mark. You're welcome to leave any comments, too.

Also, these orphaned ways that aren't part of any relations but the user has tagged as boundary=administrative

And these should be reviewed last, after the municipal boundaries has been reviewed:

Please double-check if there's anything else that was missed.

govvin commented 3 years ago

FYI, the local Kaart team will be supporting this effort, and will devote some cycles towards resolving this issue asap.

Timmy-Tesseract commented 3 years ago

Finished tasks, ticked off in above list:

Newly finished tasks:

Additional relations missing on list:

VMPanes commented 3 years ago

Completed these two tasks:

govvin commented 3 years ago

Great progress, everyone! Thank you for your help. Also, it should be noted that the mapper also contributed to reverting some of their own edits.

image

Last night @seav mentioned that the grayscale Mapnik layer is not updated as often as the mainstream layers, and I confirm that it should be possible to "recycle" old elements (that's a tip we previously learned from @ianlopez1115 ) to restore the old geometry, like so:

image

The end-point for grayscale Mapnik tiles is : https://tiles.wmflabs.org/bw-mapnik/{z}/{x}/{y}.png

govvin commented 3 years ago

Removed adjustments made by c4rlo on the following elements, and restore old geometry based on Mapnik grayscale

Additional features not found in original tasking list:

VMPanes commented 3 years ago

Completed these three items from the list:

govvin commented 3 years ago

Awesome job folks! Kudos to @seav @ianlopez1115 @Timmy-Tesseract @VMPanes for all your help! We also acknowledge the efforts made by c4rlo to rectify the issue.

Unless there's any more outstanding issues, this ticket seems complete.

If you can, please review the area with your favorite QA tools, to identify any issue we might have missed - and fix them, if possible, before we close this ticket.

govvin commented 3 years ago

Again, good job, folks, and thank you very much for helping out.

Closing this ticket now, and c4rlo sends their thanks to the local community, for helping resolve the concern.

image