OSOceanAcoustics / echopop

Generating biological estimates for animal "pop"ulation from echosounder data
https://echopop.readthedocs.io/
Apache License 2.0
1 stars 4 forks source link

Review and rendering of example notebooks for github rendering #56

Closed emiliom closed 2 weeks ago

emiliom commented 1 year ago

Review and current state

In PR #53 we ran into the limitations of GitHub Jupyter notebook previewing. Some of those limitations are well known and expected (eg, elements that involve interactive HTML or JavaScript will typically not be rendered), but others are unexpected and more severe (large blocks of cells are not displayed at all).

In that PR we also decided to try to include all 5 current notebooks in example_notebooks in a rendered form. That goal is outside the scope of PR #53 and will be tracked here.

Apparently github notebook previewing is not just limited but also glitchy, such that things that worked one day may be broken the following day. I have a hunch that the missing block of cells may be one such glitch and is temporary. However, I also learned that what's encoded in the notebook when run and saved, and how it's then rendered by github, has some dependence on the conda environment used. I tested this via a couple of gists:

Preliminary recommendation

While unrendered cell output is to be expected for interactive elements in the github preview, omitted cells (and especially large blocks of cells!) are problematic because the presentation of the notebooks could be very misleading. Trying to minimize this problem will probably take too much (ie, time consuming) fine tuning, and this may be a transient github problem to begin with.

I suggest we shift our energy towards deploying a very simple JupyterBook instead, where we can ensure the notebooks are nicely rendered. Then, the decision about whether to have rendered or unrendered notebooks in example_notebooks can be made independently. The JupyterBook would be the starting point for the eventual EchoPro documentation.

Notes

emiliom commented 1 year ago

Some of this was completed and included in release 0.3.0. Keeping the issue open, though, to track other topics discussed here.

brandynlucca commented 2 weeks ago

The current example workbook file supersedes this and can therefore be closed. Some of the points discussed here may be revived in the future.