Closed eeholmes closed 3 months ago
Thanks @eeholmes. This turned out to be a necessary warning, that we were not encoding the time correctly with int64 at nanosecond resolution. The instruments likely don't have that resolution, but it's good to be faithful to what the data file contains. This is now addressed in echopype v0.8.4 via https://github.com/OSOceanAcoustics/echopype/issues/1290.
Also, the notebook failing of notebook using echopype v0.8.3 was due to the input argument change to compute_MVBS
introduced in v0.8.2. The notebook is updated in #42, so I'll close this once that's merged.
This doesn't stop the example running but this warning appears for every file. echopype 0.8.1 . Example failed (for me) with vrs 0.8.3
Output from conda list