OSOceanAcoustics / echopype-examples

Echopype example notebooks
https://echopype-examples.readthedocs.io/
Apache License 2.0
9 stars 6 forks source link

Add new hake region to NASC notebook #43

Closed leewujung closed 1 month ago

leewujung commented 3 months ago
ctuguinay commented 3 months ago

Maybe edit this title to "Add New Hake Survey Notebook Focused on Masking Hake and Hake NASC"

ctuguinay commented 3 months ago

I'll also need to put Hake EVR files in Echoregions so that I can easily read them from a notebook.

And I'll need to modify how the EK500 colormap is placed into Matplotlib's colormap, since the visualize subpackage is meant to be removed. Hopefully not a big thing to fix.

leewujung commented 3 months ago

And I'll need to modify how the EK500 colormap is placed into Matplotlib's colormap, since the visualize subpackage is meant to be removed. Hopefully not a big thing to fix.

I did the investigation when putting in the deprecation, so I just submit https://github.com/OSOceanAcoustics/echopype/pull/1336 and asked you to review. Right now if you do import echopype.colormap, then you can use cmap="ep.ek500" when plotting.

leewujung commented 3 months ago

I'll also need to put Hake EVR files in Echoregions so that I can easily read them from a notebook.

Oh right. Maybe put 1 EVR file in this repo instead of the Echoregions one, so that it is together with the notebook. In Echoregions I feel a minimal example like what you have is nice. I guess this is the place where we could actually put it in the release assets, so that it gets bundled with the next release of echopype-examples. I haven't looked into the operations though, seems something we can do a hackday with, to also get the initial stuff going to migrate Echopype test files.

ctuguinay commented 3 months ago

Sounds good, I'll place it in this repo. I think another PR to place stuff in release assets would be good though, after this one is merged.