search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
96 stars 72 forks source link

Change most AZFP Vendor-specific attributes to data variables #1055

Closed leewujung closed 1 year ago

leewujung commented 1 year ago

Many of the current Vendor-specific group attributes for AZFP can (and should) be changed to data variables. This is something discovered while @lsetiawan was working on #1042. The code changes in #1042 should handle the new data variables without problem, so it is a matter of putting these changes in place.

This is a leftover from #1042.

lsetiawan commented 1 year ago

@aniketfadia96 I've assigned you to this, figured this would get you some experience with xarray. Please consult @leewujung for direction. Thanks!

aniketfadia96 commented 1 year ago

@lsetiawan Okay I'll look into this. Thank you!

lsetiawan commented 1 year ago

To let you know about some vocabulary:

AZFP is the instrument type of echosounder and Vendor-specific is a group within the set of datasets. This group is essentially an xarray dataset object.

These attributes are assigned in https://github.com/OSOceanAcoustics/echopype/blob/main/echopype/convert/set_groups_azfp.py#L329. Currently there are actual data within the attributes of this dataset, but we'd like to make it into data_vars or DataArray objects instead.

leewujung commented 1 year ago

I'll pick up this issue now because we need this for the upcoming release and for generating a CDL for the sonarnetcdf4-echopype-checker.

aniketfadia96 commented 1 year ago

Hey @leewujung @lsetiawan, sorry I couldn't work on this issue. I was occupied with my primary project.

leewujung commented 1 year ago

Addressed in #1075 .