OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
95 stars 73 forks source link

`consolidate` subpackage functions need to accept both in-memory or stored datasets #1129

Closed leewujung closed 9 months ago

leewujung commented 1 year ago

From discussion with @Sohambutala: Some functions in the subpackage consolidate such as add_location and add_splitbeam_angle have inconsistent support for whether or not non-in-memory Sv or EchoData datasets are allowed as inputs. In a workflow sense it is much better to allow stored netcdf or zarr files that contains these datasets, so we should add the support uniformly for functions in the consolidate.

Some specific notes: