Closed leewujung closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Merging #1136 (4429311) into dev (3407147) will decrease coverage by
8.38%
. The diff coverage is100.00%
.:exclamation: Current head 4429311 differs from pull request most recent head 65f6596. Consider uploading reports for the commit 65f6596 to get more accurate results
@@ Coverage Diff @@
## dev #1136 +/- ##
==========================================
- Coverage 80.41% 72.04% -8.38%
==========================================
Files 65 4 -61
Lines 6046 186 -5860
==========================================
- Hits 4862 134 -4728
+ Misses 1184 52 -1132
Flag | Coverage Δ | |
---|---|---|
unittests | 72.04% <100.00%> (-8.38%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files Changed | Coverage Δ | |
---|---|---|
echopype/commongrid/api.py | 94.33% <ø> (-1.07%) |
:arrow_down: |
echopype/commongrid/nasc.py | 0.00% <ø> (-91.43%) |
:arrow_down: |
echopype/commongrid/__init__.py | 100.00% <100.00%> (ø) |
... and 61 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Temporarily remove
commongrid.compute_NASC
, because the current implementation ofcompute_NASC
may contain unintended bugs related to units and a scaling factor. We'll add this back in v0.8.1.