OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
95 stars 73 forks source link

CI is not correctly raising the exit code from test #1140

Open lsetiawan opened 1 year ago

lsetiawan commented 1 year ago

Overview

I noticed that currently in dev branch the tests are "passing". However, looking at the actual output log here There are actual some failures in the test, but it's still showing green checkmark.

I think the issue here is that using tee to capture the logs is not allowing the actual test exit code to be raised, but rather the success of writing to log file. Need to find a better way to do this so that we can both capture the log and raise the appropriate error code.

emiliom commented 1 year ago

I noticed this behavior in a recent PR! But it's clearly not consistent, since we do get CI failures due to test failures

leewujung commented 1 year ago

Thanks for adding this issue. I noticed that too and ran all tests locally before merging.