OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
95 stars 73 forks source link

test: Remove NASC import causing failure #1145

Closed lsetiawan closed 1 year ago

lsetiawan commented 1 year ago

Commented out import for 'compute_NASC' causing the only error in CI at the moment seen in https://github.com/OSOceanAcoustics/echopype/actions/runs/6032689378/job/16368234856#step:11:1539 and https://github.com/OSOceanAcoustics/echopype/actions/runs/6032689378/job/16368234931#step:11:1539

codecov-commenter commented 1 year ago

Codecov Report

Merging #1145 (e9d5b4a) into dev (31b0665) will decrease coverage by 4.66%. Report is 6 commits behind head on dev. The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1145      +/-   ##
==========================================
- Coverage   79.78%   75.13%   -4.66%     
==========================================
  Files          65        4      -61     
  Lines        6011      185    -5826     
==========================================
- Hits         4796      139    -4657     
+ Misses       1215       46    -1169     
Flag Coverage Δ
unittests 75.13% <ø> (-4.66%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 63 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

lsetiawan commented 1 year ago

Please ignore 3.8 test. See https://github.com/OSOceanAcoustics/echopype/issues/1144