search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
95 stars 73 forks source link

`consolidate.add_depth` outputs to work with `compute_MVBS` #1152

Closed leewujung closed 2 months ago

leewujung commented 1 year ago

In the overhaul of compute_MVBS (currently in the working in #1124) the variable water_depth is propagated down in the MVBS dataset. We should review what variables are needed to be propagated down, now that we have standardized the z-axis variables in v0.8.0, and some more improvements/refinement of add_depth will be introduced soon by @emiliom.

Relevant code section: https://github.com/lsetiawan/echopype/blob/5a963bd397980583827bac2b6ba0b4bdd6ccf8cc/echopype/commongrid/api.py#L164-L166 This is in the PR code so may change in the future.

emiliom commented 1 year ago

Note: the variable that's now propagated is called water_level, not water_depth.

leewujung commented 4 months ago

This will be addressed potentially under #1205 or another PR that addresses the same thing.