OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
95 stars 73 forks source link

ci: Temporarily remove Python 3.11 [all tests ci] #1156

Closed leewujung closed 1 year ago

leewujung commented 1 year ago

This PR temporarily removes Python 3.11 testing and packaging until parsed2zarr overhaul is completed, which likely would either remove more_itertools as a dependency or unpin it (currently pinned to more_itertools=8.13.0).

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov-commenter commented 1 year ago

Codecov Report

Merging #1156 (da9ddda) into dev (00ee579) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1156   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files          64       64           
  Lines        5803     5803           
=======================================
  Hits         4779     4779           
  Misses       1024     1024           
Flag Coverage Δ
unittests 82.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

leewujung commented 1 year ago

Hey @lsetiawan : I am very puzzled by why in the "experimental" 3.11 testing runs tests like echopype/tests/convert/test_parsed_to_zarr.py::test_raw2zarr[noaa_offloaded] did not fail, but when 3.11 is tested for real, the same test would fail.

All of the failure is related to the use of more_itertools in the current parsed2zarr module. That library was pinned to 8.13.0, but the latest is already 10.1.0. I am hope in #1070 you can either completely remove this dependency or unpin it. For v0.8.1, I'll temporarily remove 3.11 just to be safe. Thanks!