search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
94 stars 73 forks source link

Explore inefficiencies in `cal_params.py` #1163

Closed lsetiawan closed 10 months ago

lsetiawan commented 11 months ago

There's a potential inefficiency in EK60 and EK80 'cw' data. See code below of where this might be.

https://github.com/OSOceanAcoustics/echopype/blob/3ca028f04a4fd3643bb0ad350dc09a699883ee1e/echopype/calibrate/cal_params.py#L291-L297

anantmittal commented 11 months ago

Command to run the tests and capture the stdout: python .ci_helpers/run-test.py --local --pytest-args="-vvrP" echopype/calibrate/cal_params.py

lsetiawan commented 11 months ago

Pytest Run

pytest -vvrP echopype/tests/calibrate/test_cal_params.py::test_get_vend_cal_params_power
leewujung commented 10 months ago

This issue now is captured more fully in #1200. @lsetiawan @anantmittal : you may wanna close this and copy-paste the above comments there.