Feature/add multichannel masks

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis

https://echopype.readthedocs.io/

Apache License 2.0

94 stars 73 forks source link

Feature/add multichannel masks #1177

Closed ruxandra-valcu closed 5 months ago

ruxandra-valcu commented 11 months ago

This PR introduces multichannel mask functionality to apply_mask

if a single-channel mask is provided as argument, it will be applied to all channels of the dataset
if a multi-channel mask is provided as argument, its channels will be applied individually

leewujung commented 11 months ago

Hey @ruxandra-valcu : Thanks for the PR! Could you revert the new commits so that this PR only contains changes that are relevant to the multi-channel mask support? It is very difficult to figure out what was changed otherwise. From a quick look the actually changes are small, so I will be able to review quickly. Thanks!

ruxandra-valcu commented 11 months ago

Reverted,sorry about that!

leewujung commented 11 months ago

Thanks, I'll get to this very soon!

leewujung commented 5 months ago

I'll close this now as it is being addressed as part of #1230.