search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
94 stars 73 forks source link

Fixtures to generate mock data for clean up `use_swap` handling #1183

Closed leewujung closed 11 months ago

leewujung commented 11 months ago

@lsetiawan : in this PR you'll find functions that generate mock data for testing the use_swap functionality for #1179.

I made it such that the output is in identical format with parser.ping_data_dict, for timestamp, power, and angle.

See my comment here for more info: https://github.com/OSOceanAcoustics/echopype/issues/1179#issuecomment-1737733489

Because of the possible variations, I think using both the actual data for integration tests and mock data for unittest will be a good idea.

In terms of actual .raw data that we need to handle, see my previous investigation https://github.com/OSOceanAcoustics/echopype/issues/489#issuecomment-968340670 and https://github.com/OSOceanAcoustics/echopype/issues/489#issuecomment-968342133.

leewujung commented 11 months ago

BTW, the tests WILL fail because I only did the short-circuiting to make it easy to see how data looks like without the zarr_datagrams business. I did not try to fix anything downstream, because they need to be removed.

lsetiawan commented 11 months ago

Merged in #1185