Closed lsetiawan closed 10 months ago
Merging #1192 (da84598) into dev (ce1e614) will decrease coverage by
4.85%
. Report is 1 commits behind head on dev. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #1192 +/- ##
==========================================
- Coverage 81.89% 77.04% -4.85%
==========================================
Files 67 67
Lines 5887 5908 +21
==========================================
- Hits 4821 4552 -269
- Misses 1066 1356 +290
Flag | Coverage Δ | |
---|---|---|
unittests | 77.04% <100.00%> (-4.85%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
echopype/convert/parse_azfp.py | 93.53% <100.00%> (+0.33%) |
:arrow_up: |
echopype/convert/set_groups_azfp.py | 97.95% <100.00%> (+0.25%) |
:arrow_up: |
... and 8 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Looks good, thanks! I made one small inline comment. My only other comment is that it looks like the files .ci_helpers/py${{ matrix.python-version }}.yaml
are no longer used; or are they actually used in other actions? If not, let's delete them, right?
re they actually used in other actions?
Looks like they're still being used in the windows-utils-test
shenanigans that I'm not sure what it's doing. Probably good to have a tests clean up soon that include this stuff.
Looks like they're still being used in the windows-utils-test shenanigans that I'm not sure what it's doing. Probably good to have a tests clean up soon that include this stuff.
Sounds good. Merge away, and thanks!!
This PR is a follow up to https://github.com/OSOceanAcoustics/echopype/pull/1191 since even new PR's are failing!
Conda is now removed from CI since there isn't any special packages that we need from there anymore and we're basically already installing via pip through conda anyways. Plus this was a recommendation from Filipe to do over the summer.