OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
91 stars 71 forks source link

Add `depth` to allowed dimension in `apply_mask` #1204

Closed leewujung closed 3 months ago

leewujung commented 8 months ago

Right now mask.apply_mask only allows datasets with range_sample as one of the dimensions along with ping_time and channel (optional). However outputs of compute_MVBS for example would have dimension depth in place of range_sample in the along-range dimension. We need to add depth into the allowed dimension in apply_mask.

ctuguinay commented 3 months ago

Closed with the merging of https://github.com/OSOceanAcoustics/echopype/pull/1230