search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
91 stars 71 forks source link

Refactored `EchoData.update_platform` to improve readability #1209

Closed praneethratna closed 8 months ago

praneethratna commented 8 months ago

Addresses #1206 and private methods of update_platform are now moved to new file utils_platform.py to improve readability.

codecov-commenter commented 8 months ago

Codecov Report

Merging #1209 (1850dbf) into dev (ab5a2bd) will increase coverage by 2.90%. The diff coverage is 97.43%.

@@            Coverage Diff             @@
##              dev    #1209      +/-   ##
==========================================
+ Coverage   77.09%   80.00%   +2.90%     
==========================================
  Files          67       11      -56     
  Lines        5924      720    -5204     
==========================================
- Hits         4567      576    -3991     
+ Misses       1357      144    -1213
Flag Coverage Δ
unittests 80.00% <97.43%> (+2.90%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
echopype/echodata/echodata.py 75.00% <100.00%> (-2.89%) :arrow_down:
echopype/echodata/utils_platform.py 97.22% <97.22%> (ø)

... and 58 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

praneethratna commented 8 months ago

@leewujung I think this can be merged as well! Thanks!

leewujung commented 8 months ago

Oh right, thanks for reminding!