search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
96 stars 72 forks source link

Improve `estimate_noise` binning routine #1211

Closed lsetiawan closed 2 months ago

lsetiawan commented 11 months ago

Overview

This issue follows up on Issue https://github.com/OSOceanAcoustics/echopype/issues/1028. Improvements in 2D binning routines have been implemented for both compute_MVBS and compute_NASC, however it may seem that estimate_noise is still left as mentioned in the issue.

https://github.com/OSOceanAcoustics/echopype/blob/f98e825e808a98dfdf43f66c8be242347d353e3b/echopype/clean/noise_est.py#L53-L81

An investigation and improvements needs to happen for this method to enhance efficiency, memory usage, and robustness against different types of data.

Original description by @leewujung can be found at https://github.com/OSOceanAcoustics/echopype/issues/1028#issue-1662507356.

MohamedNasser8 commented 5 months ago

Hello @lsetiawan, As I understand it, ping_time can refer to actual timestamps or simply be a sequence of indices. We need to account for both scenarios: when ping_time represents real-time data and when it represents indices. I am making sure to handle both cases appropriately to ensure accurate results.

ctuguinay commented 2 months ago

Closing this as coarsen itself is very fast and probably does not need the Flox algorithms to speed up this process.