search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
96 stars 72 forks source link

Move `complex` data type reshaping to parser rather than during rectangularize #1213

Closed lsetiawan closed 10 months ago

lsetiawan commented 11 months ago

Overview

In PR https://github.com/OSOceanAcoustics/echopype/pull/1185, after the swap mechanism was refactored, @leewujung made a suggestion to port over the complex data type reshaping to the parser object rather than during a rectangularization step.

See TODO below:

https://github.com/OSOceanAcoustics/echopype/blob/499866f34266f1748c192e8d88a0931f39e8efa3/echopype/convert/parse_base.py#L294-L296

The referenced function is found below

https://github.com/OSOceanAcoustics/echopype/blob/499866f34266f1748c192e8d88a0931f39e8efa3/echopype/convert/utils/ek_raw_parsers.py#L1534-L1633

_Originally posted by @leewujung in https://github.com/OSOceanAcoustics/echopype/pull/1185#discussion_r1385160862_

leewujung commented 11 months ago

Hey @praneethratna : Would you be willing to take this up, since you are familiar with the parser? I think [all test ci] would need to be used for the PR, to make sure all tests get run through, since the parser downstream is everything. Thanks!

praneethratna commented 11 months ago

@leewujung sure yes! i'll take this up. Thanks!

leewujung commented 11 months ago

Thank you!