OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
91 stars 71 forks source link

Removed the unused `ALL` param in parser object. #1214

Closed praneethratna closed 8 months ago

praneethratna commented 8 months ago

Addresses https://github.com/OSOceanAcoustics/echopype/issues/857 by removing unused "ALL" param in parser object.

Based on PR #1203 since that PR got messed up while resolving merge conflicts.

CC @leewujung

codecov-commenter commented 8 months ago

Codecov Report

Merging #1214 (dce34a0) into dev (499866f) will decrease coverage by 5.24%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1214      +/-   ##
==========================================
- Coverage   83.13%   77.90%   -5.24%     
==========================================
  Files          63       16      -47     
  Lines        5710     2625    -3085     
==========================================
- Hits         4747     2045    -2702     
+ Misses        963      580     -383     
Flag Coverage Δ
unittests 77.90% <100.00%> (-5.24%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
echopype/convert/api.py 88.42% <ø> (-0.28%) :arrow_down:
echopype/convert/parse_ad2cp.py 91.41% <100.00%> (ø)
echopype/convert/parse_azfp.py 94.28% <100.00%> (ø)
echopype/convert/parse_base.py 87.60% <100.00%> (+2.86%) :arrow_up:
echopype/convert/parse_ek60.py 100.00% <100.00%> (+30.00%) :arrow_up:
echopype/convert/parse_ek80.py 100.00% <100.00%> (+50.00%) :arrow_up:

... and 49 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

leewujung commented 8 months ago

Great! Thanks @praneethratna. I'll merge this now!