search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
91 stars 71 forks source link

Moved `complex` data type reshaping to parser rather than during rectangularize [all tests ci] #1218

Closed praneethratna closed 8 months ago

praneethratna commented 8 months ago

Addresses #1213 and now complex data type reshaping occurs in ek_raw_parsers.py instead of in parse_base.py.

CC @leewujung @lsetiawan

praneethratna commented 8 months ago

Closing and re-opening the PR to re-run all the tests!

codecov-commenter commented 8 months ago

Codecov Report

Merging #1218 (3350007) into dev (71f0250) will decrease coverage by 0.18%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1218      +/-   ##
==========================================
- Coverage   83.44%   83.27%   -0.18%     
==========================================
  Files          64       64              
  Lines        5672     5668       -4     
==========================================
- Hits         4733     4720      -13     
- Misses        939      948       +9
Flag Coverage Δ
unittests 83.27% <100.00%> (-0.18%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
echopype/convert/parse_base.py 83.40% <ø> (-4.21%) :arrow_down:
echopype/convert/set_groups_ek80.py 98.32% <ø> (-0.01%) :arrow_down:
echopype/convert/utils/ek_raw_parsers.py 55.53% <100.00%> (+0.14%) :arrow_up:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

leewujung commented 8 months ago

@praneethratna : Awesome! I've verified everything by running all tests locally as well. Feel free to merge this. Thanks a lot!