OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
91 stars 71 forks source link

Fixes build issue with `minioci.dockerfile` [all tests ci] #1228

Closed praneethratna closed 8 months ago

praneethratna commented 8 months ago

Fixes build issue with minioci.dockerfile due to microdnf command not found.

leewujung commented 8 months ago

Hey @praneethratna : Thanks for looking into this. There are other more recent releases and one with the latest tag too. It seems better to not pin on a specific version, unless there are very good reasons to do so. Do you know what the core issues were for the previous failing, and is there a more general fix that we could use?

praneethratna commented 8 months ago

Hey @praneethratna : Thanks for looking into this. There are other more recent releases and one with the latest tag too. It seems better to not pin on a specific version, unless there are very good reasons to do so. Do you know what the core issues were for the previous failing, and is there a more general fix that we could use?

Hi @leewujung I tried to build using latest tag but that also failed due to similar error. The core issue being microdnf command was not found which can be due to microdnf not being used post Nov 1st release, i'm not very sure of it. I have a more general fix for this which is -

FROM minio/minio AS base
FROM debian AS builder
ARG TARGETPLATFORM

RUN apt-get update && apt-get install -y git
FROM minio/minio
COPY --from=builder /usr/bin/git /usr/bin/git

CMD ["minio", "server", "/data"]

What do you think about this fix?

praneethratna commented 8 months ago

Closing and re-opening the PR to rerun all the tests!

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2eaa210) 82.35% compared to head (10e4bc0) 82.35%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1228 +/- ## ======================================= Coverage 82.35% 82.35% ======================================= Files 64 64 Lines 5803 5803 ======================================= Hits 4779 4779 Misses 1024 1024 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1228/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1228/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `82.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.