OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
91 stars 71 forks source link

Fixed reshape bug in `pad_shorter_ping` and added test for EK80 missing `receiver_sampling_freq` error [all tests ci] #1234

Closed praneethratna closed 7 months ago

praneethratna commented 7 months ago

Fixed reshape bug in pad_shorter_ping and added text case to validate the fix for #1217 which was fixed in #1219.

CC @leewujung

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8ed2c7d) 83.29% compared to head (660ee07) 83.29%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1234 +/- ## ======================================= Coverage 83.29% 83.29% ======================================= Files 64 64 Lines 5675 5675 ======================================= Hits 4727 4727 Misses 948 948 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1234/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1234/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `83.29% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

leewujung commented 7 months ago

Hey @praneethratna : I just fixed the indent in the test that errored out. I think we're good to go now, so I'll merge this. Thanks!