search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
91 stars 71 forks source link

Optimize `harmonize_env_param_time` #1235

Closed anantmittal closed 4 months ago

anantmittal commented 7 months ago

Exploring #1200

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (87fd9af) 83.54% compared to head (6fb6675) 89.01%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1235 +/- ## ========================================== + Coverage 83.54% 89.01% +5.47% ========================================== Files 64 11 -53 Lines 5675 974 -4701 ========================================== - Hits 4741 867 -3874 + Misses 934 107 -827 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1235/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `89.01% <100.00%> (+5.47%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lsetiawan commented 5 months ago

@leewujung is this good to go?