OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
91 stars 71 forks source link

Remove `source_Sv_path` from `add_splitbeam_angle` #1237

Closed leewujung closed 7 months ago

leewujung commented 7 months ago

Right now there is a source_Sv_path variable created within add_splitbeam_angle, which is then used in the add_angle_to_ds function to add the newly computed angle variables to an existing dataset. Wouldn't the way to add new variables be the same for either an xr.Dataset object in memory or lazy-loaded from a path?

This was originally from https://github.com/OSOceanAcoustics/echopype/pull/1216#pullrequestreview-1740282260