search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
96 stars 72 forks source link

Optimize get_vend_cal_params_power #1238

Closed anantmittal closed 6 months ago

anantmittal commented 10 months ago

Explores #1200

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (87fd9af) 83.54% compared to head (78c73f6) 88.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1238 +/- ## ========================================== + Coverage 83.54% 88.93% +5.39% ========================================== Files 64 11 -53 Lines 5675 976 -4699 ========================================== - Hits 4741 868 -3873 + Misses 934 108 -826 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1238/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `88.93% <100.00%> (+5.39%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

leewujung commented 6 months ago

@lsetiawan : We can close this one now that #1285 has the new changes?