search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
89 stars 70 forks source link

test echo range for EK80 reduced sample rate #1270

Open MohamedNasser8 opened 4 months ago

MohamedNasser8 commented 4 months ago

Fixes #969 I don't know if the mean by reduced sampling rate is the reduced file size, if it is, The fifth test case do the same thing as me. Or I should resample the data?

leewujung commented 4 months ago

@MohamedNasser8 : My bad, I did not put in enough info the original description in #969.

Here the reduced sampling rate refers to a specific setup the EK80 instrument allows. That setup would make the discretization along the range_sample axis coarser in the EchoData object (from the open_raw function), which affects the echo_range values in the output of compute_Sv. The intention of #969 is to check the calculation against the expected values from another program. I got some sample data from a colleague from #702, and will put that somewhere for you to download, and the expected values it should be tested against.

MohamedNasser8 commented 3 months ago

@leewujung Thanks for your illustration, I'm waiting for the data to test it.

MohamedNasser8 commented 3 months ago

Hello @leewujung, I just wanted to remind you about the data I can test with.