OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
89 stars 70 forks source link

Optimize get vend cal params power #1283

Closed anujsinha3 closed 3 months ago

anujsinha3 commented 3 months ago

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.93%. Comparing base (9f56124) to head (17acfed). Report is 19 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1283 +/- ## ========================================== + Coverage 83.52% 88.93% +5.41% ========================================== Files 64 11 -53 Lines 5686 976 -4710 ========================================== - Hits 4749 868 -3881 + Misses 937 108 -829 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1283/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1283/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `88.93% <100.00%> (+5.41%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lsetiawan commented 3 months ago

@anujsinha3, looks like you were branching off main? could you update this to branch off dev instead? The base branch should be dev. Thanks!

anujsinha3 commented 3 months ago

@lsetiawan - Thanks! Have opened a new PR: https://github.com/OSOceanAcoustics/echopype/pull/1285

Closing this one without merging.