search

OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
96 stars 72 forks source link

feat: Add `regrid_Sv` functionality to be able to regrid `Sv` dataset #1291

Open lsetiawan opened 6 months ago

lsetiawan commented 6 months ago

Overview

This PR add regridding functionality for existing Sv data

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 95.29412% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.38%. Comparing base (8600a59) to head (bb257cc). Report is 38 commits behind head on dev.

Files Patch % Lines
echopype/commongrid/regrid.py 97.43% 2 Missing :warning:
echopype/utils/misc.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1291 +/- ## =========================================== - Coverage 83.80% 70.38% -13.42% =========================================== Files 64 11 -53 Lines 5705 824 -4881 =========================================== - Hits 4781 580 -4201 + Misses 924 244 -680 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1291/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1291/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `70.38% <95.29%> (-13.42%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lsetiawan commented 6 months ago

@leewujung This is currently a draft PR because I don't have tests for it yet. However, could you please start reviewing the implementation and help me try out different scenarios to make sure I have it implemented correctly? Thanks!

leewujung commented 6 months ago

@lsetiawan : Could you put in at least a couple test so that it's easier to step through the code? Thanks!