OSOceanAcoustics / echopype

Enabling interoperability and scalability in ocean sonar data analysis
https://echopype.readthedocs.io/
Apache License 2.0
89 stars 70 forks source link

Move Compute Sv Offset inside of AZFP Parser #1307

Closed ctuguinay closed 2 months ago

ctuguinay commented 2 months ago

Addresses 2/3 of #1305: Moving compute Sv inside AZFP parser and including freq info into freq-pulse error message.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.95%. Comparing base (9f56124) to head (fad5321). Report is 46 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1307 +/- ## ========================================== - Coverage 83.52% 77.95% -5.57% ========================================== Files 64 16 -48 Lines 5686 2622 -3064 ========================================== - Hits 4749 2044 -2705 + Misses 937 578 -359 ``` | [Flag](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1307/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/OSOceanAcoustics/echopype/pull/1307/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics) | `77.95% <100.00%> (-5.57%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OSOceanAcoustics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctuguinay commented 2 months ago

@leewujung this is ready to review now

ctuguinay commented 2 months ago

@leewujung used that argsort. that section is cleaner now 😎

leewujung commented 2 months ago

Great, thanks! I'll merge this now.